Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codeclimate & Editorconfig support #896

Merged
merged 3 commits into from Dec 6, 2016

Conversation

Projects
None yet
3 participants
@bhubbard
Copy link
Contributor

commented Nov 17, 2016

Added support for CodeClimate set to use WordPress standards. Also added WordPress default .editorconfig file.

@lukecarbis

This comment has been minimized.

Copy link
Contributor

commented Dec 6, 2016

@bhubbard Talk me through why this project should be using CodeClimate? We already use Travis for this sort of thing.

@bhubbard

This comment has been minimized.

Copy link
Contributor Author

commented Dec 6, 2016

@lukecarbis CodeClimate is more of a linter style tool, it will run checks for css, markdown, js, php coding standards. It will provide an overall GPA score, and a list of issues by category.

In fact CodeClimate will actually integrate with Travis-CI.

https://docs.travis-ci.com/user/code-climate/
https://docs.codeclimate.com/docs/setting-up-test-coverage

You can see what it reports now, but its not that accurate as the configs are not setup for WordPress PHP Standards yet:
https://codeclimate.com/github/xwp/stream

@lukecarbis lukecarbis merged commit 9f1d977 into xwp:develop Dec 6, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bhubbard bhubbard deleted the bhubbard:codeclimate-support branch Dec 6, 2016

@ntwb

This comment has been minimized.

Copy link

commented Dec 7, 2016

The css-lint, scss-lint, and eslint analysis engines do not support WordPress coding Standards

I also don't see this changing anytime soon either, I'd suggest you remove those analysis engines from your Code Climate configurations as they will affect that GPA significantly

@lukecarbis

This comment has been minimized.

Copy link
Contributor

commented Dec 7, 2016

The other thing is ignoring the libraries.

@ntwb

This comment has been minimized.

Copy link

commented Dec 7, 2016

p.s. WordPress Coding Standards for CSS with stylelint and Js with ESLint can be found:
https://github.com/ntwb/stylelint-config-wordpress
https://github.com/ntwb/eslint-config-wordpress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.