Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ACF Options pages #931

Merged
merged 3 commits into from Sep 7, 2017

Conversation

Projects
None yet
2 participants
@khromov
Copy link
Contributor

commented Aug 7, 2017

Adds support for ACF Options page values.

screen shot 2017-08-07 at 19 21 17

Mentioned here: #919

I'm struggling a little bit to find a coherent log format, maybe someone has input. Right now it's hard coded to <Field name> of "settings page" option.. The crux is the only way to figure out what settings page this is on is by grabbing get_current_screen() or $_GET['page']. Neither of these provide the human-readable page name, but rather something like toplevel_page_my_settings. Would that still be better than not setting it?

I'd also like a more natural language: Option <Field name> on <Settings page name>, but the current connector can not be easily adapted to this format. Any thoughts here?

khromov added some commits Aug 7, 2017

@lukecarbis lukecarbis merged commit 768e39b into xwp:develop Sep 7, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.