Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Slack alert implementation #962

Merged
merged 12 commits into from Apr 6, 2018

Conversation

Projects
None yet
6 participants
@robbiet480
Copy link
Contributor

commented Mar 5, 2018

Unlike the old "Stream to Slack" plugin that didn't have any kind of alerting options or rich notifications, this does. Rich notifications look like this:

screen shot on 2018-03-04 at 18_41_49

Luke Carbis and others added some commits Sep 12, 2017

Luke Carbis
Luke Carbis
Luke Carbis
Fix a notice where $old_roles indices are not properly sorted
Because of this [`array_filter`](https://github.com/WordPress/WordPress/blob/master/wp-includes/class-wp-user.php#L474) call, `$old_roles`'s first member might not always be at the zero index ( if it is not actually a valid role ).
Merge pull request #944 from xwp/bugfix/issue-943
Fix WP_CLI namespace collision
Merge pull request #940 from shadyvb/patch-1
Fix a notice where $old_roles indices are not properly sorted
@lkraav

This comment has been minimized.

Copy link

commented Mar 5, 2018

Wow, nice. Unfortunately the development team here seems to be super-busy with other projects. Anybody here know what the future plans are for Stream?

Itmw, I will patch my copies with this, and test it on a couple of production situations. Will report back once done.

@DavidCramer

This comment has been minimized.

Copy link
Member

commented Apr 3, 2018

@robbiet480 This is very nice. Would it be possible for you to clean up the code to adhere to the required coding standards so that they pass the build?
It would be a great help and I would love to get onto testing this fully.

Thanks!

@DavidCramer
Copy link
Member

left a comment

Please reformat for coding standards, thanks!

@DavidCramer DavidCramer changed the base branch from develop to add/slack-alert Apr 6, 2018

@DavidCramer DavidCramer merged commit 47d00f2 into xwp:add/slack-alert Apr 6, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@lkraav

This comment has been minimized.

Copy link

commented Apr 6, 2018

Is the .DS_Store file merged intentionally?

@DavidCramer

This comment has been minimized.

Copy link
Member

commented Apr 7, 2018

@lkraav it was? where?

@robbiet480

This comment has been minimized.

Copy link
Contributor Author

commented Apr 7, 2018

Only thing I see is addition of .DS_Store to the .gitignore...

@DavidCramer

This comment has been minimized.

Copy link
Member

commented Apr 7, 2018

ye, and that is intentional. oh well. The new PR is here #970

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.