Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grunt build and .min prefix to scripts and styles #973

Merged
merged 9 commits into from Apr 20, 2018

Conversation

Projects
None yet
2 participants
@DavidCramer
Copy link
Member

commented Apr 17, 2018

@lukecarbis - There may be a merge conflict here since I branched from master, and there are some unit test issues. But, it can still be reviewed and I'll fix any issues if needed.

Addresses #942

DavidCramer added some commits Apr 17, 2018

@DavidCramer DavidCramer requested a review from lukecarbis Apr 17, 2018

DavidCramer and others added some commits Apr 18, 2018

@lukecarbis
Copy link
Contributor

left a comment

@DavidCramer Minimising and adding a grunt build is well overdue! Thanks for your comprehensive changes.

Could you please also ammend the README to include setup, build, and deployment instructions (npm init, the various grunt tasks, etc.)?

@lukecarbis

This comment has been minimized.

Copy link
Contributor

commented Apr 19, 2018

#975 Needs to be merged before this (to resolve the failing Travis build).

DavidCramer and others added some commits Apr 19, 2018

@lukecarbis lukecarbis merged commit 75e6ee0 into develop Apr 20, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@lukecarbis lukecarbis deleted the add/942-minimize-assets branch Apr 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.