Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cast to match compare type for php7.1+ compatibility #974

Merged
merged 1 commit into from Apr 19, 2018

Conversation

Projects
None yet
2 participants
@DavidCramer
Copy link
Member

commented Apr 17, 2018

Since there's a mathematical equation on this $key, it needs to be an integer type. This casts it as such. The string cast, is just for consistency.

Fixes #952

@lukecarbis lukecarbis merged commit 4018b8b into develop Apr 19, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@lukecarbis lukecarbis deleted the bugfix/952-numeric-compatibility branch Apr 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.