Merge pull request #82 from xwp/fix/no-results

Restyle no results
xwp · Apr 24, 2020 · 89bc4bc · 89bc4bc
2 parents d8583fc + cc1fc29
commit 89bc4bc
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 9 deletions.
diff --git a/assets/images/no-results.png b/assets/images/no-results.png
diff --git a/assets/src/media-selector/style.css b/assets/src/media-selector/style.css
@@ -86,7 +86,7 @@
 	right: 300px;
 	text-align: center;
 	left: 0;
-	top: 35px;
+	top: 34%;
 }
 
 .media-frame-content[data-columns="2"] .unsplash-attachment:nth-child(even) .thumbnail,
@@ -124,8 +124,11 @@
 		0 0 0 3px #0073aa;
 }
 
-.media-frame .unsplash-browser .no-media img {
-	width: 400px;
+.media-frame .unsplash-browser .no-media h2 {
+	font-size: 20px;
+	line-height: 1.4;
+	font-weight: 400;
+	margin: 0;
 }
 
 .wp-core-ui .unsplash-browser .unsplash-attachment img {

diff --git a/assets/src/media-selector/views/images_browser.js b/assets/src/media-selector/views/images_browser.js
@@ -104,10 +104,7 @@ const ImagesBrowser = wp.media.view.AttachmentsBrowser.extend( {
 		} );
 
 		this.attachmentsNoResults.$el.addClass( 'hidden no-media' );
-		this.attachmentsNoResults.$el.html(
-			`<img src="${ noResults.image }" alt="${ noResults.noMedia }"/>`
-		);
-		this.attachmentsNoResults.$el.append( `<p>${ noResults.noMedia }</p>` );
+		this.attachmentsNoResults.$el.append( `<h2>${ noResults.noMedia }</h2>` );
 
 		this.views.add( this.attachmentsNoResults );
 

diff --git a/php/class-plugin.php b/php/class-plugin.php
@@ -169,8 +169,7 @@ public function enqueue_media_scripts() {
 					],
 				],
 				'noResults' => [
-					'noMedia' => __( 'No results found', 'unsplash' ),
-					'image'   => $this->asset_url( 'assets/images/no-results.png' ),
+					'noMedia' => __( 'No items found.', 'unsplash' ),
 				],
 
 			]

diff --git a/tests/phpunit/php/class-test-plugin.php b/tests/phpunit/php/class-test-plugin.php
@@ -89,6 +89,20 @@ public function test_register_meta() {
 		$this->assertArrayHasKey( 'unsplash_exif', $keys );
 	}
 
+	/**
+	 * Test for register_taxonomy() method.
+	 *
+	 * @see Plugin::register_taxonomy()
+	 */
+	public function test_register_taxonomy() {
+		$plugin = get_plugin_instance();
+		$plugin->register_taxonomy();
+
+		$this->assertTrue( taxonomy_exists( 'media_tag' ) );
+		$this->assertTrue( taxonomy_exists( 'media_source' ) );
+		$this->assertTrue( taxonomy_exists( 'unsplash_user' ) );
+	}
+
 	/**
 	 * Test for enqueue_media_scripts() method.
 	 *