Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trac 34893: Improve Customizer setting validation model #136

Closed
wants to merge 22 commits into from

Conversation

Projects
None yet
2 participants
@westonruter
Copy link
Collaborator

commented Dec 8, 2015

westonruter and others added some commits May 16, 2016

Clean up CSS
[ci skip]
Remove error class from notifications container, move to data-type at…
…tribute on list item.

* Add data-code attribute to notification list items.
* Use compact list styles.
* Let default Notification type be error.
Incorporate design refinements as discussed in #design in slack, and …
…also fixes spacing of notifications for various cases. Indicators are only shown on menu item/widget headings when there is an error inside it (not for warnings/info).
Flesh out php/js-doc; only remove error notifications at save; fix qu…
…nit tests by adding a11y dependency.

Also remove incremented param count for `customize_sanitize_{$setting_id}` filter, since `$strict` is no longer being used.
@westonruter

This comment has been minimized.

Copy link
Collaborator Author

commented May 20, 2016

@ahmadawais

This comment has been minimized.

Copy link
Collaborator

commented May 22, 2016

Great! Thanks for the props :) Looking forward to contribute in the Customize Post Project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.