Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that previewed changes apply on get_pages filter #241

Closed
westonruter opened this issue Sep 2, 2016 · 0 comments

Comments

Projects
None yet
1 participant
@westonruter
Copy link
Contributor

commented Sep 2, 2016

The call to get_pages() may be (rightly) cached because it is used to build an entire tree of all posts. However, because the value may be cached, it will not respected the current customized state, besides the fact that it doesn't use WP_Query to begin with.

  • Call \WP_Customize_Posts_Preview::preview_setup_postdata() on each of the items in the get_pages filter.
  • Ensure that newly-added pages are included and appear in the right sort order.
  • Ensure newly added posts via nav menus are included (the auto-drafts among nav_menus_created_posts). See #253.
  • Beware of the $args for get_pages (other than post_type) and how get_pages would need to get re-applied. We have to initially support (per page_attributes_meta_box): post_type, exclude_tree, sort_column.

This is a dependency for #65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.