Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use `plugins_url()` directly #133

Merged
merged 1 commit into from May 10, 2016

Conversation

Projects
None yet
2 participants
@danielbachhuber
Copy link
Contributor

commented May 10, 2016

This permits filtering of the final URL, which lets me use this plugin as a Git submodule without defining SCRIPT_DEBUG

Use `plugins_url()` directly
This permits filtering of the final URL, which lets me use this plugin as a Git submodule without defining `SCRIPT_DEBUG`

@westonruter westonruter merged commit 25f0458 into xwp:develop May 10, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.004%) to 97.717%
Details
@westonruter

This comment has been minimized.

Copy link
Contributor

commented May 11, 2016

@danielbachhuber why not use Composer with WordPress Packagist instead? This would then include compiled and minified JS. Eventually if we use Browserify, using a submodule won't be an option.

@danielbachhuber danielbachhuber deleted the handbuilt:use-plugins-url-directly branch May 11, 2016

@danielbachhuber

This comment has been minimized.

Copy link
Contributor Author

commented May 11, 2016

why not use Composer with WordPress Packagist instead?

Because I'm managing dependencies with Git submodules. Also, I like the option to be able to easily contribute back while I'm working on the project.

@westonruter

This comment has been minimized.

Copy link
Contributor

commented May 11, 2016

OK, cool. But then eventually you'd need to run grunt build anyway if we do any Browserify compilation, right?

@danielbachhuber

This comment has been minimized.

Copy link
Contributor Author

commented May 11, 2016

But then eventually you'd need to run grunt build anyway if we do any Browserify compilation, right?

Well, this would break my use of the project completely. My preference would be that you always commit a built copy of the assets to the repo.

@westonruter

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2016

@danielbachhuber You may not need to filter your script and style URLs anymore due to #249

@danielbachhuber

This comment has been minimized.

Copy link
Contributor Author

commented Sep 6, 2016

Cool, thanks for the heads up 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.