Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all postmeta settings for registered types not just the ones actually referenced #141

Merged

Conversation

Projects
None yet
2 participants
@westonruter
Copy link
Contributor

commented May 19, 2016

This fixes an issue whereby you add a control for a given postmeta but the control won't appear unless the postmeta is explicitly referenced via a get_post_meta() call sine this is when the setting gets added and thus exported from the preview to the pane.

While it could be argued that it is expected behavior for a control to not appear if the postmeta is not referenced in the preview, there may very well be postmeta manipulated for a given post that doesn't appear in the preview since you may be on an archive page.

@valendesigns valendesigns merged commit ff33352 into develop May 21, 2016

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on develop at 97.636%
Details

@valendesigns valendesigns deleted the bugfix/add-settings-for-all-registered-postmeta branch May 21, 2016

@westonruter westonruter added this to the 0.6 milestone Jun 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.