Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for setting validation in 4.6-alpha #150

Merged
merged 14 commits into from Jun 1, 2016

Conversation

Projects
None yet
2 participants
@westonruter
Copy link
Contributor

commented May 26, 2016

image

Validation for post locking and post conflicts is only applied at save.

Post locking:

image

Post conflicts:

image

Fixes #142.

@westonruter westonruter added this to the 0.6 milestone May 26, 2016

@valendesigns

This comment has been minimized.

Copy link
Member

commented May 31, 2016

@westonruter I'm getting some weird errors with this PR

issues

@valendesigns

This comment has been minimized.

Copy link
Member

commented May 31, 2016

Glad we cleared that up, having the Customize Setting Validation plugin active and not the most recent version was the issue.

@valendesigns valendesigns merged commit abe952a into develop Jun 1, 2016

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.3%) to 95.561%
Details

@valendesigns valendesigns deleted the feature/trac-34893-validation branch Aug 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.