Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selecting input for newly-inserted post's first control #206

Merged
merged 6 commits into from Aug 2, 2016

Conversation

Projects
None yet
2 participants
@westonruter
Copy link
Contributor

commented Aug 1, 2016

This probably failed with the switch to embedding controls upon expanding a post section.

Fixes #209.

@westonruter westonruter added this to the 0.7 milestone Aug 1, 2016

@@ -341,6 +341,15 @@
section.postFieldControls.post_title = control;
api.control.add( control.id, control );

// Select the input's contents when the value is a placeholder.
control.deferred.embedded.done( function() {
control.container.find( ':input' ).on( 'focus', function() {

This comment has been minimized.

Copy link
@sayedtaqui

sayedtaqui Aug 2, 2016

Collaborator

@westonruter What is the use of selecting all input/textarea/select/button ( :input ) when post title field will only be input? I mean why not just use input ?

This comment has been minimized.

Copy link
@westonruter

westonruter Aug 2, 2016

Author Contributor

True. It could just be input.

@westonruter westonruter merged commit 9194a52 into develop Aug 2, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@westonruter westonruter deleted the bugfix/select-first-control-upon-insertion branch Aug 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.