Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use notification.setting instead of notification.data.setting #238

Merged
merged 1 commit into from Sep 1, 2016

Conversation

Projects
None yet
1 participant
@westonruter
Copy link
Contributor

commented Sep 1, 2016

@westonruter westonruter added this to the 0.8 milestone Sep 1, 2016

@westonruter westonruter added the bug label Sep 1, 2016

@westonruter

This comment has been minimized.

Copy link
Contributor Author

commented Sep 1, 2016

Since notification.data && notification.data.setting doesn't work in core today, there's no harm in merging a check for notification.setting now, even though #37890 isn't merged.

@westonruter westonruter merged commit 57a5703 into develop Sep 1, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@westonruter westonruter deleted the bugfix/notification-setting branch Sep 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.