Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure post_author is string in PHP but keep int in JS #251

Merged
merged 1 commit into from Sep 9, 2016

Conversation

Projects
None yet
1 participant
@westonruter
Copy link
Contributor

commented Sep 9, 2016

Align with a core oddity of WP_Post that post_author is a string as opposed to an int. See https://core.trac.wordpress.org/ticket/22324

The post_author value will remain a Number in JavaScript and will not be casted to a String.

@westonruter westonruter added this to the 0.8.0 milestone Sep 9, 2016

@westonruter westonruter merged commit 0fd04c8 into develop Sep 9, 2016

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 94.844%
Details

@westonruter westonruter deleted the bugfix/post-author-type branch Sep 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.