Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync page changes to Static Front Page section controls; prevent same page from being used as both page for posts and page on front #270

Conversation

Projects
None yet
1 participant
@westonruter
Copy link
Contributor

commented Sep 16, 2016

Continuation of #190.

Fixes #153.

Eduard Maghakyan and others added some commits Jun 26, 2016

Merge branch 'bugfix/153' of https://github.com/EduardMaghakyan/wp-cu…
…stomize-posts into feature/sync-page-changes-to-static-front-page-section-controls
Extend syncing of page data to all dropdown-pages controls beyond pag…
…e_on_front & page_for_posts

* Ensure that the settings associated with the dropdown-pages controls get cleared if trashed pages are selected.
* Show "(no title)" in option if no page title is supplied.
* Use jQuery selectors instead of iteration.
* Show (Trashed) with pages in dropdown-pages options that are disabled ].
pageOption.text( optionText );
}

// @todo In the case of page_on_front and page_for_posts, this should only be done if it wouldn't mean that they can be set to the same. See https://github.com/xwp/wp-customize-object-selector/pull/22

This comment has been minimized.

Copy link
@westonruter

westonruter Sep 16, 2016

Author Contributor

This can be handled with a new integration specific for these two settings, at the component level itself.

@westonruter westonruter changed the title Fix: Sync page changes to Static Front Page section controls Sync page changes to Static Front Page section controls; prevent same page from being used as both page for posts and page on front Sep 17, 2016

@westonruter westonruter merged commit f523e8b into develop Sep 17, 2016

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.003%) to 94.838%
Details

@westonruter westonruter deleted the feature/sync-page-changes-to-static-front-page-section-controls branch Sep 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.