Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop continuous ajax requests in select2 #351

Merged
merged 1 commit into from Apr 19, 2017

Conversation

Projects
None yet
2 participants
@sayedtaqui
Copy link
Collaborator

commented Apr 19, 2017

Issue: When we type to select a post in post-select-lookup select2 input , it sends continuous ajax requests for each letter we type without any delay. Ideally the previous request should cancel each time a new request is sent and there should be at least some delay. This PR fixes that issue.

Example of Issue:
select2-issue

@sayedtaqui sayedtaqui requested a review from westonruter Apr 19, 2017

@@ -69,7 +69,10 @@
});
request.done( success );
request.fail( failure );
}

return request;

This comment has been minimized.

Copy link
@sayedtaqui

sayedtaqui Apr 19, 2017

Author Collaborator

select2 already handles aborting the request for us if we return request in transport method.

This comment has been minimized.

Copy link
@westonruter

westonruter Apr 19, 2017

Contributor

Excellent

@westonruter westonruter added this to the Next Minor Release milestone Apr 19, 2017

@westonruter westonruter merged commit e43f9e8 into develop Apr 19, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@westonruter westonruter deleted the bugfix/select2-continuous-ajax-requests branch Apr 19, 2017

@westonruter westonruter modified the milestones: Next Minor Release, 0.8.6 Jun 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.