Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow snapshots to be named #19

Closed
westonruter opened this issue Apr 26, 2016 · 6 comments

Comments

Projects
None yet
3 participants
@westonruter
Copy link
Contributor

commented Apr 26, 2016

When listing snapshots in the admin (#12), the snapshots should be shown with a given name to easily identify what is contained in the snapshot (this would be beyond any settings listed below the snapshot when expanded, as mentioned in #18).

In addition to a name, we could make use of the post_excerpt to capture a “commit message” for a given snapshot.

Alternatively, we could just use the post title as the commit message and not have a separate name field at all.

@valendesigns valendesigns added this to the 0.5.0 milestone Jun 12, 2016

@westonruter westonruter modified the milestones: 0.5.0, 0.6.0 Aug 6, 2016

@valendesigns

This comment has been minimized.

Copy link
Member

commented Aug 11, 2016

I think we should add the ability to modify the title and excerpt. However, we filter the excerpt in the post table to display the modified settings at a glance and adding a commit log in the excerpt would override our ad hoc one, or at the very least append to it. Something to keep in mind.

@westonruter

This comment has been minimized.

Copy link
Contributor Author

commented Aug 11, 2016

If we just use the title field alone for the name (commit message) that would probably be simplest.

@westonruter

This comment has been minimized.

Copy link
Contributor Author

commented Aug 12, 2016

I think this change would necessitate changing the new “snapshot scheduling” box to be a more general “snapshot properties“ box. In addition to the scheduled date, this box would also have the title (commit message) for the snapshot. The calendar icon could then be replaced with a the edit icon, and the existing edit icon could be replaced with a “pop-out” icon.

customize__wordpress_develops_ _just_another_customizer-driven_site_

/cc @PatelUtkarsh

@PatelUtkarsh

This comment has been minimized.

Copy link
Collaborator

commented Aug 16, 2016

@westonruter With this change should we also change the workflow of how one can schedule snapshots?

Currently, On Creation, User first has to save snapshot and then only he can schedule a snapshot in the customizer.
Calendar icon is not visible when there is no snapshot loaded/created.

@westonruter

This comment has been minimized.

Copy link
Contributor Author

commented Aug 16, 2016

@PatelUtkarsh good question. Maybe that could all stay the same, but upon the initial Save the text field would be made available to let them supply a title and re-save to make it stick?

@PatelUtkarsh

This comment has been minimized.

Copy link
Collaborator

commented Aug 19, 2016

image
@westonruter @valendesigns New UI, let me know your thoughts :)

PatelUtkarsh added a commit that referenced this issue Aug 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.