Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate with changesets in WP 4.7 #102

Merged
merged 137 commits into from Feb 6, 2017

Conversation

Projects
None yet
5 participants
@PatelUtkarsh
Copy link
Collaborator

commented Nov 16, 2016

Fixes #99

**Snapshot Actions: **

1 - Hit "Publish" Button

  • Publish ( Without Confirming )

2 - Select "Publish” from dropdown

  • Confirm Publish.
  • If clicked again
    • Publish.

3 - Select “Save Draft” / “Save Pending" from status -

  • Change changesetStatus to draft / pending.
  • Save as draft / pending.

4 - Hit “Draft” / “Pending" button

  • Save as draft / pending

5 - Select “Schedule” from dropdown

  • Show the edit box
  • If date is of future
    • Change changesetStatus to “future”
    • Save changeset.
    • If title/date is changed.
      • Auto Save title/date entered.
  • If date is not of future
    • Show notification to change date to future.

6 - Auto Save happens from core

  • If current status is publish
    • Save as “auto-draft” ( by default )
  • If current status is pending / draft
    • Let the changeset save as the current status ( pending / draft )
  • If current status is future.
    • Save with future date
    • If the selected date is not of future
      • Save changeset to the previous future date used.
  • If “Confirm Publish” is the text in button.
    • Save changeset to the current status ( pending/ draft/ future ).

Issues:

  • When selecting “Publish” from the dropdown, the button changes to “Confirm Publish”. If you then click in into the preview or allow the autosave logic to run, then it goes ahead and publishes even though you never click the button. Additionally, the changeset UUID doesn't get removed from the URL.

@PatelUtkarsh PatelUtkarsh changed the title Integrate Changeset [WIP] Integrate Changeset Nov 16, 2016

@coveralls

This comment has been minimized.

Copy link

commented Jan 17, 2017

Coverage Status

Coverage decreased (-13.8%) to 76.831% when pulling 351098d on refactor/intergrate-changeset into 629033d on develop.

@coveralls

This comment has been minimized.

Copy link

commented Jan 23, 2017

Coverage Status

Coverage decreased (-13.8%) to 76.831% when pulling 0846554 on refactor/intergrate-changeset into 629033d on develop.

2 similar comments
@coveralls

This comment has been minimized.

Copy link

commented Jan 23, 2017

Coverage Status

Coverage decreased (-13.8%) to 76.831% when pulling 0846554 on refactor/intergrate-changeset into 629033d on develop.

@coveralls

This comment has been minimized.

Copy link

commented Jan 23, 2017

Coverage Status

Coverage decreased (-13.8%) to 76.831% when pulling 0846554 on refactor/intergrate-changeset into 629033d on develop.

@coveralls

This comment has been minimized.

Copy link

commented Jan 30, 2017

Coverage Status

Coverage decreased (-13.8%) to 76.831% when pulling db331d9 on refactor/intergrate-changeset into 629033d on develop.

@coveralls

This comment has been minimized.

Copy link

commented Jan 30, 2017

Coverage Status

Coverage decreased (-13.8%) to 76.831% when pulling 9eff34a on refactor/intergrate-changeset into 629033d on develop.

@coveralls

This comment has been minimized.

Copy link

commented Jan 31, 2017

Coverage Status

Coverage decreased (-13.8%) to 76.831% when pulling 06733f7 on refactor/intergrate-changeset into 629033d on develop.

@coveralls

This comment has been minimized.

Copy link

commented Jan 31, 2017

Coverage Status

Coverage decreased (-13.8%) to 76.831% when pulling 4fb959a on refactor/intergrate-changeset into 629033d on develop.

public function show_migration_notice() {
?>
<div class="notice notice-error customize-snapshot-migration">
<p><?php esc_html_e( 'Existing snapshots need to be migrated in changesets in WordPress 4.7.', 'customize-snapshots' );

This comment has been minimized.

Copy link
@valendesigns

valendesigns Feb 3, 2017

Member

I think this should read a bit more like this:

Existing Snapshots need to be migrated to Changesets, which was added to Core in WordPress 4.7. Click here to start the migration.

PatelUtkarsh and others added some commits Feb 6, 2017

@westonruter westonruter added this to the 0.6.0 milestone Feb 6, 2017

@westonruter westonruter changed the title [WIP] Integrate Changesets in WP 4.7 Integrate with changesets in WP 4.7 Feb 6, 2017

@westonruter westonruter merged commit 09bd418 into develop Feb 6, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@westonruter westonruter deleted the refactor/intergrate-changeset branch Feb 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.