New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workaround to pretend customize_save ajax action is happening during changeset publishing #137

Merged
merged 1 commit into from Jul 13, 2017

Conversation

Projects
None yet
2 participants
@westonruter
Contributor

westonruter commented Jul 13, 2017

To quote from https://core.trac.wordpress.org/ticket/39221#comment:14

Anne Louise Currie found a defect in core related to this, specifically in publishing a changeset from outside the Customizer, such as via the edit post screen as provided by the Customize Snapshots plugin. In particular, publishing changes to options will fail due to the preview filters being added.

I have amended the PR with a fix: xwp/wordpress-develop@3e4dea4

This PR implements a hacky workaround to make sure that preview logic is not invoked for settings.

@westonruter westonruter requested a review from PatelUtkarsh Jul 13, 2017

@PatelUtkarsh

👍

@westonruter westonruter modified the milestone: 0.6.1 Jul 13, 2017

@westonruter westonruter merged commit dc978f9 into develop Jul 13, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@westonruter westonruter deleted the fix/changeset-publishing-preview-prevention branch Jul 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment