Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade for WP 4.9 and remove back-compat for <4.7 #162

Merged
merged 57 commits into from Nov 16, 2017

Conversation

Projects
None yet
3 participants
@westonruter
Copy link
Contributor

commented Oct 21, 2017

  • Conditionally incorporate #161 when on 4.9+.
  • Make sure features not merged into core are ported into customize-snapshots.js, including changeset title and saving the current previewed URL and expanded panels/sections as meta when saving a changeset, etc.
  • Fix autosave requests. They currently fail with a changeset_post_save_failure for edit_others_posts. There is some conflict between setting the caps in \CustomizeSnapshots\Post_Type::extend_changeset_post_type_object() and the logic to in \WP_Customize_Manager::grant_edit_post_capability_for_changeset() when performing an autosave request.
  • Update changeset title when user sitting on customizer and schedule time arrived.
  • Test and fix how pending state is saved when user does not have publish capability.

Testing:

  • Test if able to publish changeset from front end in compat and 4.9
  • Test if able to merge changesets in compat and 4.9
  • Test if snapshot admin post edit screen is working as expected in compat and 4.9
  • Test state query vars are saved properly in compat and 4.9
  • Test if able to create multiple changesets in compat and 4.9
  • Overall testing

westonruter added some commits Oct 21, 2017

Remove compat code for WP older than 4.7
Also fix add_snapshot_uuid_to_return_url logic to only include customize_changeset_uuid in return_url when referer had it to begin with.

@westonruter westonruter requested a review from sayedtaqui Oct 21, 2017

@coveralls

This comment has been minimized.

Copy link

commented Oct 21, 2017

Coverage Status

Coverage increased (+5.4%) to 80.279% when pulling 922a1ad on upgrade/4.9 into 3076044 on develop.

@coveralls

This comment has been minimized.

Copy link

commented Oct 23, 2017

Coverage Status

Coverage increased (+5.4%) to 80.279% when pulling 081e066 on upgrade/4.9 into 3076044 on develop.

@westonruter westonruter added this to the 0.7.0 milestone Oct 30, 2017

@coveralls

This comment has been minimized.

Copy link

commented Oct 30, 2017

Coverage Status

Coverage increased (+5.5%) to 80.357% when pulling 3993bff on upgrade/4.9 into 3076044 on develop.

1 similar comment
@coveralls

This comment has been minimized.

Copy link

commented Oct 30, 2017

Coverage Status

Coverage increased (+5.5%) to 80.357% when pulling 3993bff on upgrade/4.9 into 3076044 on develop.

@coveralls

This comment has been minimized.

Copy link

commented Nov 2, 2017

Coverage Status

Coverage increased (+5.5%) to 80.377% when pulling 54059d2 on upgrade/4.9 into 3076044 on develop.

@sayedtaqui sayedtaqui removed their request for review Nov 2, 2017

@coveralls

This comment has been minimized.

Copy link

commented Nov 2, 2017

Coverage Status

Coverage increased (+5.5%) to 80.377% when pulling 0b5ef52 on upgrade/4.9 into 3076044 on develop.

@coveralls

This comment has been minimized.

Copy link

commented Nov 8, 2017

Coverage Status

Coverage increased (+5.5%) to 80.377% when pulling 86722c8 on upgrade/4.9 into 3076044 on develop.

@coveralls

This comment has been minimized.

Copy link

commented Nov 8, 2017

Coverage Status

Coverage increased (+5.5%) to 80.377% when pulling d471abf on upgrade/4.9 into 3076044 on develop.

@westonruter

This comment has been minimized.

Copy link
Contributor

commented on js/customize-snapshots.js in 4c6d2c8 Nov 8, 2017

Let's use “inspect” instead of “edit” when linking to the edit post screen. Editing is done in the Customizer. See #155.

@coveralls

This comment has been minimized.

Copy link

commented Nov 14, 2017

Coverage Status

Coverage increased (+6.0%) to 80.859% when pulling 868b6b5 on upgrade/4.9 into 3076044 on develop.

@coveralls

This comment has been minimized.

Copy link

commented Nov 14, 2017

Coverage Status

Coverage increased (+6.0%) to 80.859% when pulling 18514d5 on upgrade/4.9 into 3076044 on develop.

sayedtaqui added some commits Nov 14, 2017

@coveralls

This comment has been minimized.

Copy link

commented Nov 14, 2017

Coverage Status

Coverage increased (+6.007%) to 80.892% when pulling 558ef8f on upgrade/4.9 into 3076044 on develop.

@coveralls

This comment has been minimized.

Copy link

commented Nov 14, 2017

Coverage Status

Coverage increased (+5.3%) to 80.211% when pulling 558ef8f on upgrade/4.9 into 3076044 on develop.

@coveralls

This comment has been minimized.

Copy link

commented Nov 14, 2017

Coverage Status

Coverage increased (+5.3%) to 80.211% when pulling 96b247e on upgrade/4.9 into 3076044 on develop.

@westonruter

This comment has been minimized.

Copy link
Contributor Author

commented Nov 15, 2017

@sayedtaqui anything left here as far as you know?

@sayedtaqui

This comment has been minimized.

Copy link
Collaborator

commented Nov 15, 2017

I think this is it. I will do more testing before you wake up.

@coveralls

This comment has been minimized.

Copy link

commented Nov 15, 2017

Coverage Status

Coverage increased (+5.3%) to 80.211% when pulling 026839a on upgrade/4.9 into 3076044 on develop.

@coveralls

This comment has been minimized.

Copy link

commented Nov 15, 2017

Coverage Status

Coverage increased (+5.3%) to 80.211% when pulling 026839a on upgrade/4.9 into 3076044 on develop.

@coveralls

This comment has been minimized.

Copy link

commented Nov 15, 2017

Coverage Status

Coverage increased (+5.3%) to 80.211% when pulling da511c4 on upgrade/4.9 into 3076044 on develop.

3 similar comments
@coveralls

This comment has been minimized.

Copy link

commented Nov 15, 2017

Coverage Status

Coverage increased (+5.3%) to 80.211% when pulling da511c4 on upgrade/4.9 into 3076044 on develop.

@coveralls

This comment has been minimized.

Copy link

commented Nov 15, 2017

Coverage Status

Coverage increased (+5.3%) to 80.211% when pulling da511c4 on upgrade/4.9 into 3076044 on develop.

@coveralls

This comment has been minimized.

Copy link

commented Nov 15, 2017

Coverage Status

Coverage increased (+5.3%) to 80.211% when pulling da511c4 on upgrade/4.9 into 3076044 on develop.

@coveralls

This comment has been minimized.

Copy link

commented Nov 15, 2017

Coverage Status

Coverage increased (+5.3%) to 80.211% when pulling a2a1ee7 on upgrade/4.9 into 3076044 on develop.

@coveralls

This comment has been minimized.

Copy link

commented Nov 16, 2017

Coverage Status

Coverage increased (+5.3%) to 80.211% when pulling 952a754 on upgrade/4.9 into 3076044 on develop.

@westonruter westonruter merged commit feba7ab into develop Nov 16, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@westonruter westonruter deleted the upgrade/4.9 branch Nov 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.