New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix previewing widgets in snapshots #34

Merged
merged 2 commits into from Jun 7, 2016

Conversation

Projects
None yet
3 participants
@westonruter
Contributor

westonruter commented Jun 7, 2016

The CustomizeSnapshots\Customize_Snapshot_Manager::can_preview() method gets called alter anyway in \CustomizeSnapshots\Customize_Snapshot_Manager::preview() before the setting actually gets previewed. So we don't need to call it earlier. We can just populate the unsanitized post values as early as we can, and then the Customizer will pick up the settings on its own.

Nevertheless, I think we can actually get rid of can_preview altogether. See #26.

Fixes #33.

@coveralls

This comment has been minimized.

coveralls commented Jun 7, 2016

Coverage Status

Coverage increased (+0.4%) to 83.333% when pulling 1465ae0 on bugfix/widgets into 8b0b742 on master.

@westonruter westonruter changed the title from Set post value without creating dynamic settings to Fix previewing widgets in snapshots Jun 7, 2016

@valendesigns valendesigns merged commit b32cb69 into master Jun 7, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@valendesigns valendesigns deleted the bugfix/widgets branch Jun 7, 2016

@westonruter westonruter modified the milestone: 0.4.0 Jun 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment