Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show list of settings in snapshot in excerpt #46

Merged
merged 5 commits into from Jun 12, 2016

Conversation

Projects
None yet
2 participants
@westonruter
Copy link
Contributor

commented Jun 11, 2016

image

Fixes #45.
Fixes #42.

@westonruter

This comment has been minimized.

Copy link
Contributor Author

commented Jun 11, 2016

@valendesigns I found lots of references to dirty even though it now was basically unused, in 31602e0.

@valendesigns

This comment has been minimized.

Copy link
Member

commented Jun 11, 2016

The reference to dirty is to add only settings to the snapshot that are dirty. It doesn't have anything to do with dirty or full scope during the playback.

@westonruter

This comment has been minimized.

Copy link
Contributor Author

commented Jun 11, 2016

We shouldn't be adding things to a snapshot if they aren't dirty to begin with though.

@valendesigns

This comment has been minimized.

Copy link
Member

commented Jun 11, 2016

That's what the dirty check in set was for. 😀

@westonruter

This comment has been minimized.

Copy link
Contributor Author

commented Jun 11, 2016

@valendesigns I mean from the JS side of things. We shouldn't be sending a request that contains both dirty and non-dirty settings, right?

@westonruter

This comment has been minimized.

Copy link
Contributor Author

commented Jun 12, 2016

@valendesigns there, see deb0ddd.

@valendesigns

This comment has been minimized.

Copy link
Member

commented Jun 12, 2016

@valendesigns valendesigns merged commit 6c60f02 into release/0.4.0 Jun 12, 2016

@valendesigns valendesigns deleted the feature/excerpt-setting-list branch Jun 12, 2016

@westonruter westonruter modified the milestone: 0.4.0 Jun 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.