Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass (snapshot object) to customize_snapshot_save filter. #77

Merged
merged 5 commits into from Aug 22, 2016

Conversation

Projects
None yet
3 participants
@lgedeon
Copy link
Contributor

commented Aug 20, 2016

No description provided.

@coveralls

This comment has been minimized.

Copy link

commented Aug 20, 2016

Coverage Status

Coverage remained the same at 90.797% when pulling 8c5953a on feature/pass-snapshot into 856d135 on develop.

@westonruter

This comment has been minimized.

Copy link
Contributor

commented Aug 20, 2016

A unit test should be added for the save method to verify that the snapshot object is passed as the second filter param.

@westonruter

This comment has been minimized.

Copy link
Contributor

commented Aug 20, 2016

Such a test will help guard against the filter getting inadvertently removed or changed and thus breaking plugins that make use of it.

lgedeon added some commits Aug 21, 2016

@coveralls

This comment has been minimized.

Copy link

commented Aug 21, 2016

Coverage Status

Coverage remained the same at 90.797% when pulling d22d95c on feature/pass-snapshot into 856d135 on develop.

@coveralls

This comment has been minimized.

Copy link

commented Aug 22, 2016

Coverage Status

Coverage remained the same at 90.797% when pulling 7110036 on feature/pass-snapshot into 856d135 on develop.

@coveralls

This comment has been minimized.

Copy link

commented Aug 22, 2016

Coverage Status

Coverage remained the same at 90.797% when pulling 17b82dd on feature/pass-snapshot into 856d135 on develop.

@westonruter westonruter merged commit 089cf81 into develop Aug 22, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@westonruter westonruter deleted the feature/pass-snapshot branch Aug 22, 2016

@westonruter westonruter added this to the 0.5.1 milestone Aug 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.