New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve compatibility with plugins (e.g. Jetpack Widget Visibility module) #39
Comments
Also the styling of the widget restriction controls is lacking, if that module is enabled. |
Eliminates a warning from Jetpack. See #39.
Widget form controls expect to be set up on the widgets page, so the actions triggered on that page need to be manually triggered here (just like the Ajax handler does) The widgets page also exposes an ajaxurl global JavaScript variable which the Customizer does not export, so we have to set it as well. Lastly, many widgets expect for their controls to be rendered inside of a div#widgets-right which does not exist in the customizer, so we have to make one of the divs in the customizer have that ID for compatability. See #39
@shaunandrews speaking of |
There's also a bug with the Jetpack Widget Visibility module in that it assumes widgets are always multi-widgets, and that they are not old single widgets. Submitted patch to the Jetpack ticket which was opened 3 weeks ago: http://plugins.trac.wordpress.org/ticket/1979 |
The Jetpack Widget Visibility module expects the widget templates to be rendered into the DOM as hidden elements so that it can inject the "Visibility" button in the proper place. So we have to move the templates from the model and into the DOM for compat. Addendum to #39
Reported by @shaunandrews:
Either the Jetpack plugin is not extending widgets properly, or the Widget Customizer is not adequately setting up the environment for rendering widget controls in the customizer.
The text was updated successfully, but these errors were encountered: