New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark controls for widgets not rendered on URL currently previewed #65

Open
westonruter opened this Issue Dec 16, 2013 · 3 comments

Comments

Projects
None yet
1 participant
@westonruter
Contributor

westonruter commented Dec 16, 2013

Currently the sidebar sections in the customizer will show/hide based on which sidebars are used on a given page (see #2). You can click around inside of the customizer to navigate to a page, and if that page template uses different sidebars, you'll see the sections in the customizer change while navigating.

It doesn't, however, hide widgets from the sidebar sections if they aren't currently rendered in the sidebar (e.g. via Widget Context or Jetpack's Widget Visibility). Perhaps the widget controls could be made opaque or minimized, for example:

image

See also: http://make.wordpress.org/core/2013/12/16/better-widgets/#comment-12125

westonruter added a commit that referenced this issue Jan 2, 2014

Fade widgets not rendered in sidebars on currently-previewed URL
A 50% opacity is applied to the widget form controls when the widget
is not rendered in the preview, for example if the Jetpack Widget
Visibility module is used to exclude the widget from the page.

When navigating to other URLs in the preview, the appearance of the
widget controls will update based on whether or not the widget is
rendered on the newly-previewed URL. As such, this is the same
behavior as the sidebar sections.

Also fixed bug in relation to Widget Visibility where widgets not
initially-rendered in the preview could not then subsequently be
updated or previewed.

Fixes #65

@westonruter westonruter closed this Jan 2, 2014

@westonruter

This comment has been minimized.

Show comment
Hide comment
@westonruter

westonruter Jan 13, 2014

Contributor

@MichaelArestad will mock up adding "This widget is not on the current page." to the inactive widgets.

Contributor

westonruter commented Jan 13, 2014

@MichaelArestad will mock up adding "This widget is not on the current page." to the inactive widgets.

@westonruter westonruter reopened this Jan 13, 2014

@westonruter

This comment has been minimized.

Show comment
Hide comment
@westonruter

westonruter Jan 26, 2014

Contributor

@MichaelArestad I'm going to close this issue. Any further improvements to the UI can be presented by you via a separate pull request.

Contributor

westonruter commented Jan 26, 2014

@MichaelArestad I'm going to close this issue. Any further improvements to the UI can be presented by you via a separate pull request.

@westonruter

This comment has been minimized.

Show comment
Hide comment
@westonruter

westonruter Jan 30, 2014

Contributor

The logic for detecting whether a widget is rendered or not is not quite right it seems. The unpopulated RSS widget doesn't render anything, so it would seem like it should by default be semi-transparent. But when you first load the Customizer, it is fully opaque. If you try updating the widget or move it to another sidebar, it then becomes semi-transparent as expected.

Contributor

westonruter commented Jan 30, 2014

The logic for detecting whether a widget is rendered or not is not quite right it seems. The unpopulated RSS widget doesn't render anything, so it would seem like it should by default be semi-transparent. But when you first load the Customizer, it is fully opaque. If you try updating the widget or move it to another sidebar, it then becomes semi-transparent as expected.

@westonruter westonruter reopened this Jan 30, 2014

@ghost ghost assigned westonruter Jan 30, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment