New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed signature include MessageBusObserver - cleanup #10

Closed

TorbenSiegismund-GIP opened this issue Apr 3, 2024 · 0 comments · Fixed by #15

Labels

breaking change cleanup

Contributor

TorbenSiegismund-GIP commented Apr 3, 2024

In message-bus.service.ts:

Remove customMessageReceivedSubject and correseponding calls
Remove signature addCustomMessageSubscription(subscription: XoMessage). Only allow calls with two inputs.
Remove signature removeCustomMessageSubscription(subscription: XoMessage). Only allow calls with two inputs.

TorbenSiegismund-GIP added the breaking change cleanup label

TorbenSiegismund-GIP mentioned this issue

Use Observer Pattern for Custom Messages in Message Bus Service #8

Closed

PatrickVonMassow-GIP closed this as completed

LukasFey-GIP reopened this

LukasFey-GIP linked a pull request

that will close this issue

changed signature include messagebusobserver - cleanup #15

Merged

LukasFey-GIP closed this as completed in #15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment