Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finished porting Value to Typescript #190

Merged
merged 1 commit into from Jul 26, 2018

Conversation

Projects
None yet
2 participants
@NQNStudios
Copy link
Contributor

NQNStudios commented Jul 24, 2018

Continuing @y-lohse's work on #189, I believe I've successfully finished porting Value.js to Value.ts.

@y-lohse

This comment has been minimized.

Copy link
Owner

y-lohse commented Jul 25, 2018

Thank you! I'll take a look at this in about 10 hours.

We'll have to rebase this because I think we comited more or less at the same time, but your changes are more advanced. I can take care of it tonight if no one has done it until then.

I'll have a bunch of TS-related questions and review comments, but I think it's easier if we do this on the other PR to avoid scattering the conversation :)

@y-lohse y-lohse merged commit 2157a46 into y-lohse:value Jul 26, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.