Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multilanguage support #4

Closed
DamionGans opened this issue May 21, 2020 · 2 comments · Fixed by #5
Closed

Multilanguage support #4

DamionGans opened this issue May 21, 2020 · 2 comments · Fixed by #5
Labels
enhancement New feature or request

Comments

@DamionGans
Copy link

Right now the logger assumes the user has an English Windows machine (mine is not).
My suggestion is instead to find an open window from the notepad.exe program and open that.
@yaakov-h yaakov-h added the enhancement New feature or request label May 21, 2020
@yaakov-h
Copy link
Owner

yaakov-h commented May 21, 2020 •
edited

Finding the window based on process name is fairly trivial, but it'll be a lot trickier to identify a window with an open or saved document versus a transient, unsaved one.

@4lexKislitsyn
Copy link
Contributor

Hi. If providing a window name is suitable way to fix this problem, I can create an PR soon. Wait for feedback.

@4lexKislitsyn 4lexKislitsyn mentioned this issue May 21, 2020
Merged
@yaakov-h yaakov-h linked a pull request May 21, 2020 that will close this issue
Added options to provider #5
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added options to provider 4lexKislitsyn/Notepad.Extensions.Logging
3 participants
@yaakov-h @4lexKislitsyn @DamionGans