Skip to content

Clearfix class not included? #45

Closed
DriesS opened this Issue Mar 25, 2013 · 4 comments

3 participants

@DriesS
DriesS commented Mar 25, 2013

Is there a reason why the clearfix css class of bootstrap is not included in this gem?

This is in the original css of bootstrap :

.clearfix {
   *zoom: 1;
}
.clearfix:before,
.clearfix:after {
   display: table;
   content: "";
   line-height: 0;
 }
.clearfix:after {
   clear: both;
}
@yabawock
Owner

Probably because SCSS doesn't automatically creates a class for a mixin, which is different from LESS. I'll have a look and update as necessary

@DriesS
DriesS commented Mar 25, 2013

Ok thank you. Will you roll-out the update/fix on previous versions also, as we use the 2.2.2.0 version of the gem/bootstrap?

@yabawock yabawock added a commit that referenced this issue Mar 26, 2013
@yabawock Merge branch 'release/2.3.1.1'
* release/2.3.1.1:
  Bump version to 2.3.1.1
  Make clearfix mixin available as a class (Closes #45)
  Add test for #44
  Rails 4.0 on JRuby is still wonky
  Ruby 2.0.0 for Rails 3.1 is not supported
  Test against JRuby and MRI 2.0.0
  Test against Rails 4.0.0.beta1
ed4075f
@yabawock yabawock closed this in fc12aca Mar 26, 2013
@yabawock yabawock added a commit that referenced this issue Mar 26, 2013
@yabawock Merge branch 'hotfix/2.2.2.1' into support/2-2-stable
* hotfix/2.2.2.1:
  Bump version to 2.2.2.1
  Make clearfix mixin available as a class (Closes #45)
  Make input-block-level mixin available as a class
ce71472
@yabawock
Owner

Hi, I've release a version 2.2.2.1 and 2.3.1.1 for the gem, both incorporating these fixes.

@swrobel
swrobel commented Mar 26, 2013

AAAAAAAAAAGH Thanks, just spent a few hours debugging :sob:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.