Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distorted custom sticker images #206

Closed
albertbori opened this issue Dec 18, 2017 · 1 comment
Closed

Distorted custom sticker images #206

albertbori opened this issue Dec 18, 2017 · 1 comment

Comments

@albertbori
Copy link
Contributor

albertbori commented Dec 18, 2017

screen shot 2017-12-18 at 4 38 30 pm

In CLSTickerTool.m, in setStickerMenu, the line view.iconImage = [image aspectFit:CGSizeMake(50, 50)]; causes the sticker to attempt to be aspect Fit, but in CLToolbarMenuItem, the iconImageView is set to UIViewContentModeScaleAspectFill, which causes the stickers that are not perfectly square to be pixelated and clipped as in the image above.

albertbori added a commit to albertbori/CLImageEditor that referenced this issue Dec 18, 2017
@yackle
Copy link
Owner

yackle commented Jan 10, 2018

Merged #207, thanks!

@yackle yackle closed this as completed Jan 10, 2018
sahara108 added a commit to sahara108/CLImageEditor that referenced this issue Jul 22, 2018
* 'master' of https://github.com/yackle/CLImageEditor:
  Update podspec
  Fix warnings about implicity retaining self in block.
  yackle#206 Corrected sticker icon thumbnails content mode.
stansmida added a commit to percolate/CLImageEditor that referenced this issue Nov 5, 2019
… sync-upstream

* 'master' of https://github.com/yackle/CLImageEditor: (45 commits)
  Update podspec
  Use safeAreaLayoutGuide
  Add shared scheme
  Add project for Carthage
  Update podspec
  Fix warnings about implicity retaining self in block.
  yackle#206 Corrected sticker icon thumbnails content mode.
  Update podspec
  fix yackle#196
  yackle#186 set status bar hidden
  fix yackle#197
  yackle#201 Added default alphabetical sorting to custom stickers
  Fix yackle#195
  Update podspec
  Fix yackle#193
  Adjust tone curve tool menu for iPhone X
  Adjust for iPhone X
  Use auto layout
  Add launch image
  Doesn't consider CIImage backed image
  ...

# Conflicts:
#	CLImageEditor/CLImageEditor.bundle/Resources/en.lproj/Localizable.strings
#	CLImageEditor/CLImageEditorTheme.m
#	CLImageEditor/ImageTools/ToolSettings/CLToolbarMenuItem.m
#	CLImageEditor/ViewController/_CLImageEditorViewController.m
#	Demo/CLImageEditorDemo/CLImageEditorDemo/ViewController.m
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants