Permalink
Commits on Sep 23, 2010
  1. Filemanager bug fixes and improvement.

    YAEGASHI Takeshi
    YAEGASHI Takeshi committed Sep 23, 2010
    In the controller:
    - Bring CKEditorFuncNum settings across directories using session.
    - @relative_url_root for non-root URI deployment.
    
    In the view:
    - Helper functions for uncommon asset paths: js_url, css_url, img_url, ajax_url.
    - s/effetcs/effects/.
    - js cached into "filemanager.js".  Default "all.js" conflicts with other view.
    - Remove unnecessary and wrong javascript tags.
    - Use javascript_include_tag for additional js.
    - Use stylesheet_link_tag for css.
    - Use ajax_url(url_for) to get ajax entry paths.
    - Use encodeURIComponent() to correctly pass paths using GET method.
  2. Escape path string in HTML fragments for AJAX response.

    YAEGASHI Takeshi
    YAEGASHI Takeshi committed Sep 23, 2010
    The path like "Image publify#1.jpg" doesn't work without it.
  3. Reflect settings in config/ckeditor.yml.

    YAEGASHI Takeshi
    YAEGASHI Takeshi committed Sep 23, 2010
    Set PLUGIN_FILE_MANAGER_URI and PLUGIN_FILE_MANAGER_UPLOAD_URI values copying from file_manager_uri and file_manager_upload_uri respectively in config/ckeditor.yml with appropriate defaults.
    
    They are URI/path configuration for the file manager.  It's important when non-root URI deployment.
  4. Correct relative paths from /stylesheets to /images.

    YAEGASHI Takeshi
    YAEGASHI Takeshi committed Sep 23, 2010
  5. @path.rindex('.') to get correct file extension.

    YAEGASHI Takeshi
    YAEGASHI Takeshi committed Sep 23, 2010
    @path.index('.') went wrong with abc.def.jpg.
  6. Close correct tag <p>, not <div>.

    YAEGASHI Takeshi
    YAEGASHI Takeshi committed Sep 23, 2010
Commits on Sep 18, 2010
  1. Make routes work with generate_best_match = false.

    mvz committed Sep 18, 2010
    ActionController::Routing.generate_best_match = false is the new default
    for Rails 2.3.8, and the only option for Rails 3. To ease the migration to
    Rails 3, make routes work with this new setting.
Commits on Sep 12, 2010
  1. Increase spec nesting.

    mvz committed Sep 12, 2010
    - All specs now in describe AccounsController block, so no need for
      controller_name invocations.
    - Grouped 'with >0 users' specs.
Commits on Sep 11, 2010
  1. Remove encode_action_pack_request.

    mvz committed Sep 11, 2010
    Not used by Typo.
  2. Specify versions for rspec and rspec_rails.

    mvz committed Sep 11, 2010
    This is needed to avoid loading version 2.0.0, used with Rails 3.
  3. Update specs for AccountsController

    mvz committed Sep 11, 2010
    - Remove some of the duplication by using nested describes.
    - Remove some of the mocking in favor of Factory.
    - Add spec for failed password recovery.
  4. Remove useless compatibility code.

    mvz committed Sep 11, 2010
    No need to take 0.6.2 and older versions of AWS into account.
  5. Separate backend tests by API type.

    mvz committed Sep 11, 2010
    Use describe blocks to group the different API specs. Will make spec
    descriptions more concise when they are updated from their current test
    names. Also makes it easier to navigate the file.
  6. Fix library loading for BackendController and its spec.

    mvz committed Sep 11, 2010
    ActionWebService::Protocol::Discovery uses write_inheritable_array to
    register protocols. Due to the order of library loading, during testing
    only, the ApplicationController class would be created before
    ActionWebService::Protocol::XmlRpc was registered in
    ActionController::Base. This meant BackendController needed to include
    ActionWebService::Protocol::XmlRpc again in the specs to register it.
    
    By requiring 'action_web_service' in environment.rb with the other included
    libraries, we make sure it is loaded early enough to avoid this.
    
    Also, some other unneccesary require statements were removed from the spec.
  7. Remove incorrect comment.

    mvz committed Sep 11, 2010
Commits on Sep 10, 2010
  1. Remove client code from action_web_service.

    mvz committed Sep 10, 2010
    The client part of action_web_service was not used.
    
    Since the Ping model relies on XMLRPC::Client, we need to now require the
    standard Ruby 'xmlrpc/client' explicitely there.
  2. Spec out SetupController.

    mvz committed Sep 10, 2010
    Part of the ongoing quest to increase spec coverage.
  3. Remove Wsdl module from action_web_service.

    mvz committed Sep 10, 2010
    This is also not used by typo.
  4. Remove all remaining SOAP parts.

    mvz committed Sep 10, 2010
  5. Remove Soap client.

    mvz committed Sep 10, 2010
    Not used by Typo.
  6. Include spec/ when calling rcov.

    mvz committed Sep 10, 2010
    This is needed because spec_helper is required without the full path now.
Commits on Sep 9, 2010
  1. Remove explicit requires of Rails parts.

    mvz committed Sep 9, 2010
    These will already be required automatically.
Commits on Sep 8, 2010
  1. Incorporate actionwebservice.

    mvz committed Sep 8, 2010
    The actionwebservice gem is not officially maintained anymore. Rather than
    take over maintenance of that gem, incorporate its library files into Typo.
    Unused parts will be removed later.
Commits on Sep 7, 2010
  1. remove page chage fixture, never use...

    kantena authored and mvz committed Aug 29, 2010
  2. Fix specs after removal of category fixtures.

    mvz committed Sep 7, 2010
    - Add or update calls to Factory where needed.
    - Add factory sequence for category name and permalink to avoid
      validation errors.
    - Also remove categorization fixtures.
Commits on Aug 29, 2010
  1. Remove category_fixture, replace by factory

    kantena authored and mvz committed Aug 28, 2010
  2. Update article redirect specs.

    mvz committed Aug 29, 2010
    Some specs were organized illogically. There are is now a separate spec for
    redirecting from the default URL scheme if another scheme is used, and for
    using a non-ascii permalink slug. Also, some extra grouping with describe
    was introduced.
  3. Enforce use of 0.3 version of i18n gem.

    mvz committed Aug 29, 2010
    Version 0.4.1 will throw deprecation warnings for {{key}} style
    interpolations. We will get to that eventually, but for now it's just a
    distracting warning.
  4. Replace redirect fixture by factory

    kantena authored and mvz committed Aug 27, 2010
Commits on Aug 28, 2010