Adds the ability to set root level swagger values. #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yahehe
reviewed
Jan 11, 2018
| Description = "GitHub", | ||
| Url = "https://github.com/yahehe/Nancy.Swagger" | ||
| }, | ||
| schemes: new[] { Schemes.Http } |
There was a problem hiding this comment.
I assume HTTP encompasses HTTPS here?
There was a problem hiding this comment.
If it does this is good to merge, if not can we put HTTPS here instead?
There was a problem hiding this comment.
No. Http is not the same as Https in the Schemes enum.
But when someone runs this sample, it's not going to be running on HTTPS - it defaults to HTTP.
So if they want to test the endpoints, HTTP is needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows multiple values to be set on the SwaggerRoot object.
@yahehe, this seemed like the most appropriate way to do this.
I thought about giving the user the ability to just pass in a SwaggerRoot object, but I thought it was better to state which parameters will actually be set.
Fixes #147