From 5207045186091fb1d8ddced5b8ddad4d317473dc Mon Sep 17 00:00:00 2001 From: Andrey Moskvin Date: Mon, 17 Dec 2018 19:31:33 +0200 Subject: [PATCH] Tests --- PlayerCore | 2 +- sources/advertisements/AdURLProviderTests.swift | 6 +++++- .../Controllers/VRMRequestControllerTest.swift | 1 + .../metrics/detectors/vrm/VRMDetectorTests.swift | 15 +++++++++++++++ 4 files changed, 22 insertions(+), 2 deletions(-) diff --git a/PlayerCore b/PlayerCore index 8051f23..01abce1 160000 --- a/PlayerCore +++ b/PlayerCore @@ -1 +1 @@ -Subproject commit 8051f2309c183c7f550a6d5ce609073bef5b45c0 +Subproject commit 01abce184dbc6ac09653fea93ac0ce4da86e60f5 diff --git a/sources/advertisements/AdURLProviderTests.swift b/sources/advertisements/AdURLProviderTests.swift index a6b78c9..82e2c0c 100644 --- a/sources/advertisements/AdURLProviderTests.swift +++ b/sources/advertisements/AdURLProviderTests.swift @@ -75,8 +75,12 @@ class AdURLProviderTests: XCTestCase { [ item ], [ item ] ] + let response = VRMProvider.Response(transactionId: nil, + slot: "slot", + cpm: "cpm", + items:groups) - groupsContext.callbacks[0](groups) + groupsContext.callbacks[0](response) provider.queue.sync {} XCTAssertEqual(softTimeoutContext.callbacks.count, 1) diff --git a/sources/advertisements/VRM New Core/Controllers/VRMRequestControllerTest.swift b/sources/advertisements/VRM New Core/Controllers/VRMRequestControllerTest.swift index bfda907..462e8e4 100644 --- a/sources/advertisements/VRM New Core/Controllers/VRMRequestControllerTest.swift +++ b/sources/advertisements/VRM New Core/Controllers/VRMRequestControllerTest.swift @@ -71,6 +71,7 @@ class VRMRequestControllerTest: XCTestCase { return Future(value: VRMProvider.Response(transactionId: "transactionId", slot: "slot", + cpm: "cpm", items: self.itemsResponse)) }) diff --git a/sources/metrics/detectors/vrm/VRMDetectorTests.swift b/sources/metrics/detectors/vrm/VRMDetectorTests.swift index 5536942..a925296 100644 --- a/sources/metrics/detectors/vrm/VRMDetectorTests.swift +++ b/sources/metrics/detectors/vrm/VRMDetectorTests.swift @@ -35,6 +35,7 @@ class VRMDetectorTests: XCTestCase { func testEmptyDetection() { let result = detector.process( state: .init(timeoutBarrier: 3500, + cpm: nil, requestsFired: 0, request: .init(id: UUID(), timeout: .beforeSoft, @@ -45,6 +46,7 @@ class VRMDetectorTests: XCTestCase { func testVRMRequests() { let id1 = UUID() var result = detector.process(state: .init(timeoutBarrier: 3500, + cpm: nil, requestsFired: 0, request: .init(id: id1, timeout: .beforeSoft, @@ -52,6 +54,7 @@ class VRMDetectorTests: XCTestCase { XCTAssertEqual(result.count, 0) result = detector.process(state: .init(timeoutBarrier: 3500, + cpm: nil, requestsFired: 0, request: .init(id: id1, timeout: .beforeSoft, @@ -59,6 +62,7 @@ class VRMDetectorTests: XCTestCase { XCTAssertEqual(result.count, 0) result = detector.process(state: .init(timeoutBarrier: 3500, + cpm: nil, requestsFired: 0, request: .init(id: id1, timeout: .beforeSoft, @@ -74,6 +78,7 @@ class VRMDetectorTests: XCTestCase { } result = detector.process(state: .init(timeoutBarrier: 3500, + cpm: nil, requestsFired: 0, request: .init(id: UUID(), timeout: .beforeSoft, @@ -113,6 +118,7 @@ class VRMDetectorTests: XCTestCase { sut.startItems.insert(startItem1) var result = detector.process(state: .init(timeoutBarrier: 3500, + cpm: nil, requestsFired: 0, request: .init(id: id, timeout: .afterSoft, @@ -128,6 +134,7 @@ class VRMDetectorTests: XCTestCase { sut.startItems.insert(startItem1) result = detector.process(state: .init(timeoutBarrier: 3500, + cpm: nil, requestsFired: 0, request: .init(id: id, timeout: .afterSoft, @@ -138,6 +145,7 @@ class VRMDetectorTests: XCTestCase { sut.startItems.insert(startItem2) result = detector.process(state: .init(timeoutBarrier: 3500, + cpm: nil, requestsFired: 0, request: .init(id: id, timeout: .afterSoft, @@ -170,6 +178,7 @@ class VRMDetectorTests: XCTestCase { completeItem: nil) sut.completeItem = completeItem1 var result = detector.process(state: .init(timeoutBarrier: 3500, + cpm: nil, requestsFired: 0, request: .init(id: id, timeout: .afterSoft, @@ -206,6 +215,7 @@ class VRMDetectorTests: XCTestCase { completeItem: nil) sut.timeoutItems.insert(timeoutItem1) var result = detector.process(state: .init(timeoutBarrier: 3500, + cpm: nil, requestsFired: 0, request: .init(id: id, timeout: .afterSoft, @@ -219,6 +229,7 @@ class VRMDetectorTests: XCTestCase { } result = detector.process(state: .init(timeoutBarrier: 3500, + cpm: nil, requestsFired: 0, request: .init(id: id, timeout: .afterSoft, @@ -229,6 +240,7 @@ class VRMDetectorTests: XCTestCase { sut.timeoutItems.insert(timeoutItem1) sut.timeoutItems.insert(timeoutItem2) result = detector.process(state: .init(timeoutBarrier: 3500, + cpm: nil, requestsFired: 0, request: .init(id: id, timeout: .afterSoft, @@ -267,6 +279,7 @@ class VRMDetectorTests: XCTestCase { sut.otherErrorItems.insert(otherErrorItem1) var result = detector.process(state: .init(timeoutBarrier: 3500, + cpm: nil, requestsFired: 0, request: .init(id: id, timeout: .afterSoft, @@ -281,6 +294,7 @@ class VRMDetectorTests: XCTestCase { sut.otherErrorItems.insert(otherErrorItem1) result = detector.process(state: .init(timeoutBarrier: 3500, + cpm: nil, requestsFired: 0, request: .init(id: id, timeout: .afterSoft, @@ -291,6 +305,7 @@ class VRMDetectorTests: XCTestCase { sut.otherErrorItems.insert(otherErrorItem1) sut.otherErrorItems.insert(otherErrorItem2) result = detector.process(state: .init(timeoutBarrier: 3500, + cpm: nil, requestsFired: 0, request: .init(id: id, timeout: .afterSoft,