Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Fix the test failure due to express version upgrade. #9

Merged
merged 1 commit into from

3 participants

@ktslwy

The travis CI is failing due to express version upgrade. This fix updates our code with the new api. In the long term we need to not use the asterisk but a fixed version of each dependency to avoid these issues.

@travisbot

This pull request passes (merged 7635840 into 27e6c58).

@proverma proverma merged commit 66b2c44 into yahoo:master
@proverma

Thanks a lot for working on this lawrence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Aug 31, 2012
  1. @ktslwy
This page is out of date. Refresh to see the latest.
Showing with 7 additions and 8 deletions.
  1. +3 −4 arrow_server/server.js
  2. +4 −4 tests/unit/stub/seleniumserver.js
View
7 arrow_server/server.js
@@ -86,10 +86,9 @@ child.stderr.on("data", function (data) {
console.error(data.toString());
});
-var app = express.createServer(
- express.logger(),
- express.cookieParser()
-);
+var app = express();
+app.use(express.logger());
+app.use(express.cookieParser());
app.use(express.bodyParser());
var mimes = {
View
8 tests/unit/stub/seleniumserver.js
@@ -49,21 +49,21 @@ SeleniumServer.prototype.sessionsID = 1000000000000;
SeleniumServer.prototype.startServer = function() {
var self = this;
- this.server = express.createServer();
+ this.app = express();
- this.server.get("/wd/hub/sessions", function (req, res) {
+ this.app.get("/wd/hub/sessions", function (req, res) {
res.send(self.sessions);
res.end();
});
- this.server.listen(this.port);
+ this.appServer = this.app.listen(this.port);
console.log("Starting Test Selenium Server" );
}
SeleniumServer.prototype.stopServer = function() {
- this.server.close();
+ this.appServer.close();
console.log("Stopping Test Selenium Server" );
}
Something went wrong with that request. Please try again.