Support for t_page and t_rest with an extension of start_timer #12

Merged
merged 2 commits into from Apr 7, 2011

Conversation

Projects
None yet
2 participants
@hanoii
Contributor

hanoii commented Mar 18, 2011

I have worked on a tiny addition for filling in t_page and t_resp. Basically I know what we need is a timestamp of the first byte received before anything is loaded, and that should be outside boomerang namespace. I checked http://developer.yahoo.net/forum/?showtopic=6340&st=0&cookiecheckonly=1 and you mentioned about a global, but I thought this approach might be simple enough.

It's basically extending startTimer to accept a time value and adding a special handling for when the start timer is t_page.

So you basically capture firstbyte in the beginning of your HTML by doing:

var firstbyte=new Date().getTime();

And then in bottom or after the boomerang.js has been loaded, you can do:

BOOMR.plugins.RT.startTimer("t_page", firstbyte);

and that should do it.

@hanoii

This comment has been minimized.

Show comment Hide comment
@hanoii

hanoii Apr 1, 2011

Contributor

Just wondering if there's a chance this might be reviewed? Thanks and sorry to bother.

Contributor

hanoii commented Apr 1, 2011

Just wondering if there's a chance this might be reviewed? Thanks and sorry to bother.

@bluesmoon

This comment has been minimized.

Show comment Hide comment
@bluesmoon

bluesmoon Apr 7, 2011

Contributor

looking at it

Contributor

bluesmoon commented Apr 7, 2011

looking at it

@bluesmoon

This comment has been minimized.

Show comment Hide comment
@bluesmoon

bluesmoon Apr 7, 2011

could you fix the indentation here? I used tabs for indentation, but it looks like your code uses spaces.

could you fix the indentation here? I used tabs for indentation, but it looks like your code uses spaces.

@hanoii

This comment has been minimized.

Show comment Hide comment
@hanoii

hanoii Apr 7, 2011

Contributor

indentation fixed.. I did noticed some other indentation discrepancies on the code on some parts not related to this, just letting you know.

Contributor

hanoii commented Apr 7, 2011

indentation fixed.. I did noticed some other indentation discrepancies on the code on some parts not related to this, just letting you know.

@bluesmoon bluesmoon merged commit 5830f39 into yahoo:master Apr 7, 2011

@bluesmoon

This comment has been minimized.

Show comment Hide comment
@bluesmoon

bluesmoon Apr 7, 2011

Contributor

yeah, the random sampling code. i'm gonna drop that at some point

Contributor

bluesmoon commented Apr 7, 2011

yeah, the random sampling code. i'm gonna drop that at some point

@bluesmoon

This comment has been minimized.

Show comment Hide comment
@bluesmoon

bluesmoon Apr 7, 2011

Contributor

could you also update the documentation for this?

Contributor

bluesmoon commented Apr 7, 2011

could you also update the documentation for this?

@hanoii

This comment has been minimized.

Show comment Hide comment
@hanoii

hanoii Apr 7, 2011

Contributor

ha, documentation... never something that exciting to do! Sure.. will do that really soon, do review though as english is not my native language so I might miss some grammar or spelling.

Contributor

hanoii commented Apr 7, 2011

ha, documentation... never something that exciting to do! Sure.. will do that really soon, do review though as english is not my native language so I might miss some grammar or spelling.

@bluesmoon

This comment has been minimized.

Show comment Hide comment
@bluesmoon

bluesmoon Apr 7, 2011

Contributor

yeah, I'll fix any typos or errors, don't worry about that.

btw, do you feel like translating the docs to spanish (or any other language)?

Contributor

bluesmoon commented Apr 7, 2011

yeah, I'll fix any typos or errors, don't worry about that.

btw, do you feel like translating the docs to spanish (or any other language)?

@hanoii

This comment has been minimized.

Show comment Hide comment
@hanoii

hanoii Apr 8, 2011

Contributor

definitely something I can do, although probably not right now, but will try to remember and contribute it if I can.. and yes, it would be just Spanish for a proper translation.

Contributor

hanoii commented Apr 8, 2011

definitely something I can do, although probably not right now, but will try to remember and contribute it if I can.. and yes, it would be just Spanish for a proper translation.

bluesmoon referenced this pull request in bluesmoon/boomerang Jun 28, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment