Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Adapting sendBeacon function for customizing output format of the request #20

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
2 participants

Refactoring sendBeacon function for having the option for customizing formatResponse inside plugins.
This open the posibilities for modifying the output format and adapt it to the required response.

My goal is to insert the data in one step in some noSql engine or hadoop framework, for post-procesing in batchs.

Nginx+empty_gif+redis give me the ability for doing that, but the url from boomerang has to be slightly modified.
That's the reason of this little change. I hope this can be useful for other purposes too.

Thank you very much.

pd: Sorry for the bunch of lines modified, my editor kills blank spaces and it makes a lot of noise in space-limited files.
I just wrote a comment for a better understanding of the changes.

pd: My pull request was only about the first commit. I'm working on this project and now we have 4 commits in this request. Please ignore it.

@ninodafonte ninodafonte Refactoring sendBeacon function for having the option for customizing…
… formatResponse inside plugins.

This open the posibilities for modifying the output format and adapt it to the required response.

Signed-off-by: Nino Dafonte <nino.dafonte@gmail.com>
63e0024

Here you have the real changes on this file

  • sendBeacon method: refactoring for creating the request url from anohter method.
  • formatResponse method: for the real work creating the url.

I will prepare one clean request with one commit. Sorry for the inconvenients.

@ninodafonte ninodafonte closed this Aug 6, 2011

@bluesmoon bluesmoon referenced this pull request in bluesmoon/boomerang Apr 2, 2015

cvazac Merge pull request #20 from lognormal/test-hook
update copyright, test hook
7c8a601
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment