Adapting sendBeacon function for customizing output format of the request #21

Open
wants to merge 1 commit into
from

Projects

None yet

2 participants

@ninodafonte

Refactoring of the sendBeacon function for having the option for customizing formatResponse inside plugins.

This open the posibilities for modifying the output format and adapt it to the required response.

I'm trying to keep the gathering of statistical data as fast as possible and the goal is to insert the data in some noSql engine or Hadoop framework with a single request letting me make some post-processing. To do that, the url has to be in a specific format.

That's the reason for customizing the url format. I hope this could be helpful for another purposes.

Best regards, thank you very much.

pd: sorry for the bunch of line changes. My editor kills spaces and change them for tabs. I just wrote a comment to make the pull request more clear.

@ninodafonte ninodafonte Refactoring sendBeacon function for having the option for customizing…
… formatResponse inside plugins.

This open the posibilities for modifying the output format and adapt it to the required response.

Signed-off-by: Nino Dafonte <nino.dafonte@gmail.com>
63e0024
@ninodafonte

Here you have the real changes on this file

  • sendBeacon method: refactoring for creating the request url from anohter method.
  • formatResponse method: for the real work creating the url.
@bluesmoon bluesmoon commented on the diff Feb 1, 2012
boomerang.js
@@ -95,7 +95,7 @@ boomr = {
}
name = ' ' + name + '=';
-
+
@bluesmoon
bluesmoon Feb 1, 2012 Contributor

please fix all the white space changes. might be best to pull in the latest code from upstream first. also remember that we use tabs for indentation everywhere except when aligning variables.

@bluesmoon
Contributor

I think maybe this should be split into two. The StatsPlus plugin which only adds the new parameters will be one part. For the second part, we'll need to look at making this into a MVC pattern, where the formatter would be the view.

@ninodafonte

Yes, you are right,
I'll try to split this functionality as you say and i'll be back in a bit

thank you Philip!

@bluesmoon bluesmoon referenced this pull request in SOASTA/boomerang Sep 14, 2012
Closed

Custom beacon callback #1

@bluesmoon
Contributor

Just wanted to let you know that this project is now at lognormal/boomerang, so would be good if you made your changes against that repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment