Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Fix issue #18: beacon not sent when using https #26

Merged
merged 1 commit into from

2 participants

@bluesmoon

When the page_ready event fires, all event subscribers are called in
order. By default, the order is:

  • BOOMR.plugins.RT.done
  • BOOMR.plugins.BW.run

each is supposed to call BOOMR.sendBeacon() when done.

The bug in the https flow is that the BW plugin never calls
BOOMR.sendBeacon() in that block.

@bluesmoon bluesmoon Fix issue 18: beacon not sent if using https
When the page_ready event fires, all event subscribers are called in
order. By default, the order is:

- BOOMR.plugins.RT.done
- BOOMR.plugins.BW.run

each is supposed to call BOOMR.sendBeacon() when done.

The bug in the https flow is that the BW plugin never calls
BOOMR.sendBeacon() in that block.
7c9064f
@marcelduran marcelduran merged commit 3ae39d6 into yahoo:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jan 17, 2012
  1. @bluesmoon

    Fix issue 18: beacon not sent if using https

    bluesmoon authored
    When the page_ready event fires, all event subscribers are called in
    order. By default, the order is:
    
    - BOOMR.plugins.RT.done
    - BOOMR.plugins.BW.run
    
    each is supposed to call BOOMR.sendBeacon() when done.
    
    The bug in the https flow is that the BW plugin never calls
    BOOMR.sendBeacon() in that block.
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 0 deletions.
  1. +1 −0  boomerang.js
View
1  boomerang.js
@@ -1237,6 +1237,7 @@ BOOMR.plugins.BW = {
BOOMR.info("HTTPS detected, skipping bandwidth test", "bw");
impl.complete = true;
+ BOOMR.sendBeacon();
return this;
}
Something went wrong with that request. Please try again.