Merge other pull requests, measure boomerang time, fix rt.start bugs #38

Merged
merged 33 commits into from Apr 16, 2012

Conversation

Projects
None yet
6 participants
Contributor

bluesmoon commented Mar 30, 2012

There are multiple commits in this pull request. These include the following:

  • Merge in @edgarklein's change in #37
  • Few modifications to @edgarklein's pull
  • Merge in @okuryu's change in #36
  • Merge in @xzyfer's change in #35
  • Merge in @dguzzo's change in #32
  • Fix bug where rt.start was set to navigation even if using google toolbar or older chrome versions
  • Measure time it takes to load up boomerang itself
  • Set undefined and null values to '' in the beacon instead of sending 'undefined'
  • Support prerender for IE as well
  • Support W3C spec visibility change event
  • Do not use cookie time if user got to page using back button (and we know it)

dguzzo and others added some commits Feb 2, 2012

set undefined and null values to '' in the beacon
encodeURIComponent will encode undefined and null values to 'undefined'
and 'null'.  This isn't what we want in the beacon and is
indistinguishable from a string with the same value.  It's better to send
an empty string and let the back end service determine the data type and
range of the parameter
window.performance.domContentLoaded is undefined in Chrome 16 & Firef…
…ox 10. Use window.performance.domContentLoadedEventStart and window.performance.domContentLoadedEventEnd instead.
Edgar Klein
if there are already url parameters in the beacon url, change the fir…
…st parameter prefix for the boomerang url parameters to &
rename boomerang first byte time to boomr_fb since boomr_lat suggeste…
…d it was only the latency of loading boomerang
Contributor

okuryu commented Mar 30, 2012

+1

marcelduran pushed a commit that referenced this pull request Apr 16, 2012

Marcel Duran
Merge pull request #38 from bluesmoon/master
Merge other pull requests, measure boomerang time, fix rt.start bugs

@marcelduran marcelduran merged commit c33103f into yahoo:master Apr 16, 2012

bluesmoon pushed a commit to bluesmoon/boomerang that referenced this pull request Mar 21, 2016

Marcel Duran
Merge pull request #38 from bluesmoon/master
Merge other pull requests, measure boomerang time, fix rt.start bugs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment