Enforce ReadPermission for filter joins #1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aklish
requested changes
Mar 25, 2020
elide-core/src/main/java/com/yahoo/elide/core/EnforceJoinFilterExpressionVisitor.java
Outdated
Show resolved
Hide resolved
elide-core/src/main/java/com/yahoo/elide/core/EnforceJoinFilterExpressionVisitor.java
Outdated
Show resolved
Hide resolved
elide-core/src/main/java/com/yahoo/elide/core/EnforceJoinFilterExpressionVisitor.java
Outdated
Show resolved
Hide resolved
elide-integration-tests/src/test/java/com/yahoo/elide/tests/FilterIT.java
Outdated
Show resolved
Hide resolved
elide-core/src/main/java/com/yahoo/elide/core/EnforceJoinFilterExpressionVisitor.java
Outdated
Show resolved
Hide resolved
wcekan
force-pushed
the
enforce_join_filter
branch
from
5d0a8b1
to
1c22884
Compare
wcekan
force-pushed
the
enforce_join_filter
branch
from
3a3ab83
to
deb6448
Compare
wcekan
force-pushed
the
enforce_join_filter
branch
from
4d7dec7
to
2dbe0fd
Compare
aklish
approved these changes
Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enforce ReadPermission for filter joins.
Clean up duplicated filter expression builder in RequestScope.getLoadFilterExpression
Motivation and Context
Restricts filter join access to fields that pass ReadPermission.
How Has This Been Tested?
Build tests. Added additional Integration test.
Tested locally with end product.
License
I confirm that this contribution is made under an Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.