Jump to conversation Give feedback
Unresolved conversations (0)
Nice work!

Nice work!

All of your conversations have been resolved.

Resolved conversations (6)
@aklish aklish Mar 25, 2020
Can we add a Unit test for this class to test the different visitor methods?
Outdated
...e/EnforceJoinFilterExpressionVisitor.java
@wcekan
@aklish aklish Mar 25, 2020
Why does this give a bad request but the above tests returns an empty data? I suspect the RSQL filter is formatted incorrectly.
Outdated
.../java/com/yahoo/elide/tests/FilterIT.java
@wcekan
@aklish aklish Mar 25, 2020
Update the javadoc above.
.../yahoo/elide/core/PersistentResource.java
@wcekan
@aklish aklish Mar 25, 2020
Maybe a better name would be `VerifyFieldAccessFilterExpressionVisitor`
Outdated
...e/EnforceJoinFilterExpressionVisitor.java
@wcekan
@aklish aklish Mar 25, 2020
We need to negate the value of the accept.
Outdated
...e/EnforceJoinFilterExpressionVisitor.java
@wcekan
@aklish aklish Mar 25, 2020
should be left || right.
Outdated
...e/EnforceJoinFilterExpressionVisitor.java
@wcekan