Stabilizing Travis and Maven builds #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-mclawhorn
force-pushed
the
FixDeploymentSecurityBug
branch
from
c7b40e0
to
e95fcff
Compare
kevinhinterlong
approved these changes
Jul 28, 2017
| @@ -48,8 +48,8 @@ if [[ ${MAVEN_RETURN_CODE} -ne 0 ]]; then | |||
| fi | |||
|
|
|||
| # Only publish whitelisted branches | |||
| WHITELISTED=$(echo ${PUBLISH_WHITELIST} | grep ${TRAVIS_BRANCH}) | |||
| if [[ "${WHITELISTED}" == "" ]]; then | |||
| WHITELISTED=$(for a in ${PUBLISH_WHITELIST}; do if [ ${TRAVIS_BRANCH} = ${a} ]; then echo true; fi; done;) | |||
There was a problem hiding this comment.
It'd be nice if a was something like branch, but 👍
|
It appears the builds are still having some problems (#449 built fine with the new changes). This seems to be a problem with the surefire plugin |
Switchinig to openJdk
michael-mclawhorn
changed the title
saiyan86
pushed a commit
to saiyan86/fili
that referenced
this pull request
Aug 28, 2017
* Tweaking the memory *Switching to openJdk *Fixing whitelist branch bug * Cleaned up duplicated dependency warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#453
We have an issue where if a branch is a /subtring/ of a whitelisted travis branch( e.g. branch 'ast' and our whitelist branch 'master'), it will be treated like master for purpose of triggering release on push.