Permalink
Browse files

HIVE-1198. When checkstyle is activated for Hive in Eclipse environme…

…nt, it shows all checkstyle problems as errors. (Arvind Prabhakar via Ning Zhang)

git-svn-id: https://svn.apache.org/repos/asf/hadoop/hive/trunk@949342 13f79535-47bb-0310-9956-ffa450edef68
  • Loading branch information...
1 parent 7032660 commit d9cdaa7f059bb5e0bd5321e37f1fafa227610535 Ning Zhang committed May 29, 2010
Showing with 24 additions and 2 deletions.
  1. +1 −1 .checkstyle
  2. +4 −0 CHANGES.txt
  3. +15 −1 README.txt
  4. +1 −0 build.xml
  5. +3 −0 checkstyle/checkstyle.xml
View
@@ -5,6 +5,6 @@
<additional-data name="protect-config-file" value="true"/>
</local-check-config>
<fileset name="Hive Java Source Files" enabled="true" check-config-name="Hive Checkstyle" local="true">
- <file-match-pattern match-pattern="^(?!build).*java$" include-pattern="true"/>
+ <file-match-pattern match-pattern="^(?!(build|ant)).*java$" include-pattern="true"/>
</fileset>
</fileset-config>
View
@@ -193,6 +193,10 @@ Trunk - Unreleased
HIVE-1349. Do not pull counters of non initialized jobs.
(Dmytro Molkov via Ning Zhang)
+ HIVE-1198. When checkstyle is activated for Hive in Eclipse environment,
+ it shows all checkstyle problems as errors.
+ (Arvind Prabhakar via Ning Zhang)
+
OPTIMIZATIONS
BUG FIXES
View
@@ -336,7 +336,7 @@ FUTURE FEATURES
* Table statistics for query optimization.
Developing Hive using Eclipse
-------------------------
+-----------------------------
1. Follow the 3 steps in "Downloading and building" section above
2. Generate test files for eclipse:
@@ -356,6 +356,20 @@ Developing Hive using Eclipse
4. Run the CLI or a set of test cases by right clicking on one of the
*.launch configurations and selection Run or Debug.
+Enabling Checkstyle Plugin in Eclipse
+-------------------------------------
+1. Follow the steps in "Developing Hive using Eclipse" to import
+ Hive project in your Eclipse workbench.
+
+2. If you do not have Checkstyle plugin for eclipse, install it
+ before proceeding to next step. For more information refer to
+ http://eclipse-cs.sourceforge.net/.
+
+3. In the package navigator, select the hive project, right-click
+ and select Checkstyle > Activate Checkstyle. This will cause
+ the checkstyle plugin to activate and analyze the project sources.
+
+
Development Tips
------------------------
* You may use the following line to test a specific testcase with a specific query file.
View
@@ -530,6 +530,7 @@
failOnViolation="false">
<fileset dir="${hive.root}">
<exclude name="build/**"/>
+ <exclude name="ant/**"/>
<include name="**/*.java"/>
</fileset>
<formatter type="plain" toFile="${checkstyle.build.dir}/checkstyle-errors.txt"/>
@@ -50,6 +50,9 @@
<module name="Checker">
+ <!-- setting the default severity to warning -->
+ <property name="severity" value="warning"/>
+
<!-- Checks that a package.html file exists for each package. -->
<module name="JavadocPackage"/>

0 comments on commit d9cdaa7

Please sign in to comment.