Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Mojito seems to override Y.log, without maintaining the original contract #512

Closed
sdesai opened this Issue · 2 comments

3 participants

Satyen Desai Caridy Patiño Ren Waldura
Satyen Desai

On the client, Y.log seems to get displaced in mojito-client.client.js, and the new version doesn't seem to fire the log event fired by Y.log (when CE is present). As a result code listening for the log event is never notified.

Would it be better for Mojito to listen to the event itself to add custom behavior, instead of displacing the original implementation? If not, can we re-introduce the original behavior in the displaced version.

Caridy Patiño
Owner

Related to issue #70, we definitely need to clean this up. I wonder what is this logger doing that YUI logger doesn't. The only thing that I can see from the source is the new 'MOJITO' level. Now that node.js env is a first class citizen for YUI, YUI logger should support all the stuff we need, even when we don't have Y on a file, we should be able to require require('yui/yui-base') to get Y.log there.

Caridy Patiño
Owner

FYI, fixed in 0.5.0pr2, and will be documented as part of 0.5.0. Y.log is the logger in mojito, no more wrapping.

Ren Waldura rwaldura closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.