Set server runtime when handling tunnel calls. #242

Closed
wants to merge 2 commits into
from

Projects

None yet

3 participants

@FabianFrank
Contributor

The client supplies its context to the server when making a mojit proxy (tunnel call) and in this context the runtime is set to client. The server has to change the context runtime to server when reusing this context, for example to ensure proper loading of configs specified as runtime:server.

This fixes issue #236.

@FabianFrank FabianFrank Set server runtime when handling tunnel calls.
The client supplies its context to the server when making a mojit proxy (tunnel call) and in this context the runtime is set to client. The server has to change the context runtime to server when reusing this context, for example to ensure proper loading of configs specified as runtime:server.
67841d2
@drewfish
Member
drewfish commented Jul 1, 2012

+1. I think this is the right thing to do, and the right place to do it.

@FabianFrank FabianFrank UT for tunnel context.runtime verification
Adding a UT to verify that context.runtime is correctly set to server when processing /tunnel requests on the server.
290ab47
@FabianFrank
Contributor

@drewfish thanks. Please let me know if we can merge it like this, otherwise I am happy to make some changes according to your feedback.

@FabianFrank
Contributor

@drewfish @isao Can we get this with the next mojito release?

@mridgway mridgway was assigned Aug 2, 2012
@FabianFrank
Contributor

@drewfish Is there an ETA for when we can merge this one?

@mridgway
Collaborator
mridgway commented Aug 8, 2012

Hi Fabian, I'm currently investigating some regressions in our functional tests with this PR. I am expecting to have this completed by the end of the week and ready for the next release.

@mridgway
Collaborator
mridgway commented Aug 8, 2012

Functional tests passed with the latest develop branch merged. I merged your PR into develop at 1a24399 (didn't get picked up for some reason in this PR)

Thanks again @FabianFrank!

@mridgway mridgway closed this Aug 8, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment