HTMLFrameMojit enhancements #353

Closed
wants to merge 3 commits into
from

Projects

None yet

4 participants

@caridy
Collaborator
caridy commented Aug 6, 2012

First commit to clean up the tests, moving it into the proper folder, adjusting the "mojito test" to execute those tests as part of the "fw" category. This is in preparation for other commits to enhance/cleanup the current HTMLFrameMojit.

Note: I will probably include the quick fix for issue #230 as well as part of this branch.

@isao
isao commented on 17e5b4b Aug 13, 2012

+1

@drewfish drewfish commented on an outdated diff Aug 15, 2012
...ojits/HTMLFrameMojit/tests/controller.server-tests.js
@@ -0,0 +1,153 @@
@drewfish
drewfish Aug 15, 2012 Yahoo Inc. member

To match how other tests are organized withing source/lib/tests. the controller test should go in here instead: source/lib/tests/autoload/mojits/HTMLFrameMojit/controller.server-tests.js.

@caridy
Collaborator
caridy commented Aug 15, 2012

@drewfish let me change that right now.

@caridy
Collaborator
caridy commented Sep 12, 2012

@isao is this still needed after all the changes in the tests?

@isao
isao commented Sep 12, 2012

ahh this never landed? bummer. @add0n is refactoring HTMLFrameMojit, maybe he can benefit from or apply this. Otherwise I can try to clean this up if you're too busy.

@add0n
add0n commented Sep 13, 2012

Isao - Go ahead and clean this up, if you would please. The refactoring of HTMLFrameMojit is leading into a larger discussion / refactoring of how we can enhance Mojito's client capabilities (to encourage folks to push more logic client side for better performance and user experience).

@caridy
Collaborator
caridy commented Jan 18, 2013

Closing this in favor of PR #926

@caridy caridy closed this Jan 18, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment