Added "deepFreeze" and "copy" for now #513

Closed
wants to merge 2 commits into
from

2 participants

@imalberto
Yahoo Inc. member

The goal is to have the "copy" removed from expandInstanceForEnv at some point.

@imalberto
Yahoo Inc. member

@caridy Can you please review so that we can merge into search-perf ?

@caridy

@imalberto why is this condition not good anymore? Assuming that all dependencies are "addons" is incorrect, because they could be anything. At least we need a guard for addons[addonName] before calling addons[addonName](command, adapter, ac).

@caridy

For now, if we are copying when cacheValue exists and also when returning after caching, we can remove the deepFreeze for now.

@caridy

@imalberto do we need this after all? if yes, can you clean it?

@imalberto
Yahoo Inc. member

I'll close this PR. deepFreeze cost is too high. Will handle the loading of ac.addons in a separate PR.

@imalberto imalberto closed this Sep 14, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment