Skip to content

Merge assets from iconfig.assets to meta #592

Closed
wants to merge 2 commits into from

2 participants

@diervo
diervo commented Oct 4, 2012

In mojito 0.4.x due to the automatic inclusion of the mojito-assets-addon, when executing the loop on line 124 it calls the metaMergeInto of the assets addon which makes the config to merge.

Since we dont have that addon as default in the new mojito version, we will need to do it manually.

If you add the assets addon as a dependencie, due to the implementation of metaMerge will not duplicate assets. So is just a small overhead on computation in that case. 

This is a must merge to Shaker.

@diervo diervo Merge assets from iconfig.assets to meta
In mojito 0.4.x due to the automatic inclusion of the mojito-assets-addon, when executing the loop on line 124 it calls the metaMergeInto of the assets addon which makes the config to merge.
Since we dont have that automatic, we will need to do it by default.
If you add the assets addon as a dependencie, due to the implementation of metaMerge will not duplicate assets. So is just a small overhead on computation in that case. 
This is a must merge to Shaker.
d384321
@drewfish
Yahoo Inc. member
drewfish commented Oct 4, 2012

Lint error:

app/addons/ac/output-adapter.common.js
   1 123,80: Unexpected space between '}' and ')'.
     meta.assets = Y.mojito.util.metaMerge(meta.assets, config.assets || {} );
@drewfish
Yahoo Inc. member
drewfish commented Oct 4, 2012

Unit tests pass.

@diervo
diervo commented Oct 4, 2012

ok too much space xD

@diervo diervo closed this Oct 4, 2012
@diervo
diervo commented Oct 4, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.