Merge assets from config.assets to meta #593

Merged
merged 2 commits into from Oct 4, 2012

3 participants

@diervo

In mojito 0.4.x due to the automatic inclusion of the mojito-assets-addon, when executing the loop on line 124 it calls the metaMergeInto of the assets addon which makes the config to merge.

Since we dont have that addon as default in the new mojito version, we will need to do it manually.

If you add the assets addon as a dependencie, due to the implementation of metaMerge will not duplicate assets. So is just a small overhead on computation in that case.

This is a must merge to Shaker.

diervo added some commits Oct 3, 2012
@diervo diervo Merge assets from iconfig.assets to meta
In mojito 0.4.x due to the automatic inclusion of the mojito-assets-addon, when executing the loop on line 124 it calls the metaMergeInto of the assets addon which makes the config to merge.
Since we dont have that automatic, we will need to do it by default.
If you add the assets addon as a dependencie, due to the implementation of metaMerge will not duplicate assets. So is just a small overhead on computation in that case. 
This is a must merge to Shaker.
d384321
@diervo diervo Update lib/app/addons/ac/output-adapter.common.js c36e6a3
@caridy

+1

@drewfish
Yahoo Inc. member

lint passes, unit tests pass, +1

@drewfish drewfish merged commit 9af1e71 into yahoo:develop-perf Oct 4, 2012

1 check failed

Details default The Travis build failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment