Skip to content

Fix for expandinstace so we dont copy the params object #603

Merged
merged 10 commits into from Nov 6, 2012

3 participants

@diervo
diervo commented Oct 9, 2012

Performance boost!

diervo added some commits Oct 5, 2012
@diervo diervo removed lang dependencies from binders.
The langs are already dependencies of the controller so we dont need it
here. It's causing the langs to get deployed always to the client.
8ce3829
@diervo diervo expandInstance fix to avoid the param copy 0663799
@diervo diervo pull back changes 16e88bc
@drewfish
Yahoo Inc. member
drewfish commented Oct 9, 2012

This is missing child.config which is very important I suspect.

@diervo
diervo commented Oct 9, 2012

This is a Ric and I fix for avoid the overhead of copying the params. It seems that is working fine..
It was never there in the first place...

@diervo
diervo commented Oct 9, 2012

This is input to the composite addon, and in the docs seems that we dont need the config at all. It only mention params:

cfg = {
    children: {
        slot-1: {
            type: "default",
            action: "index"
        },
        slot-2: {
            type: "default",
            action: "index",
            params: {
                route: {},
                url: {},
                body: {},
                file: {}
            }
        }
    },
    assets: {}
}
@drewfish
Yahoo Inc. member
drewfish commented Oct 9, 2012

I think child.config is needed by other users.

@diervo
diervo commented Oct 9, 2012

I just added the config to the PR :)

@caridy caridy merged commit a01d12a into yahoo:develop-perf Nov 6, 2012

1 check failed

Details default The Travis build failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.